Re: [PATCH] hwmon: (nct6775) Fix register address and added missing tolerance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjoern,

On Wed, Jul 10, 2019 at 09:08:56PM +0200, Björn Gerhart wrote:
> In the process of adding the new model nct6116, two tiny details of the nct6106 attracted my attention. Please find the patch therefore below:
> 

Please sign your patches. Also, what is your baseline kernel version ?
The patch doesn't apply to the current mainline kernel.

Thanks,
Guenter

> Index: nct6775.c
> ===================================================================
> --- nct6775.c	(revision 16326)
> +++ nct6775.c	(working copy)
> @@ -866,7 +866,7 @@
>  static const u16 NCT6106_REG_WEIGHT_TEMP_SEL[] = { 0x168, 0x178, 0x188 };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_STEP[] = { 0x169, 0x179, 0x189 };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_STEP_TOL[] = { 0x16a, 0x17a, 0x18a };
> -static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x17c };
> +static const u16 NCT6106_REG_WEIGHT_DUTY_STEP[] = { 0x16b, 0x17b, 0x18b };
>  static const u16 NCT6106_REG_WEIGHT_TEMP_BASE[] = { 0x16c, 0x17c, 0x18c };
>  static const u16 NCT6106_REG_WEIGHT_DUTY_BASE[] = { 0x16d, 0x17d, 0x18d };
>  
> @@ -3778,6 +3778,7 @@
>  		data->REG_FAN_TIME[0] = NCT6106_REG_FAN_STOP_TIME;
>  		data->REG_FAN_TIME[1] = NCT6106_REG_FAN_STEP_UP_TIME;
>  		data->REG_FAN_TIME[2] = NCT6106_REG_FAN_STEP_DOWN_TIME;
> +		data->REG_TOLERANCE_H = NCT6106_REG_TOLERANCE_H;
>  		data->REG_PWM[0] = NCT6106_REG_PWM;
>  		data->REG_PWM[1] = NCT6106_REG_FAN_START_OUTPUT;
>  		data->REG_PWM[2] = NCT6106_REG_FAN_STOP_OUTPUT;



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux