On 5/27/19 5:44 PM, Guenter Roeck wrote: > On 5/17/19 4:51 PM, Marek Vasut wrote: >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >> BroadRReach 100BaseT1 PHYs used in automotive. >> >> Signed-off-by: Marek Vasut <marex@xxxxxxx> >> Cc: Andrew Lunn <andrew@xxxxxxx> >> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> >> Cc: Guenter Roeck <linux@xxxxxxxxxxxx> >> Cc: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> Cc: Jean Delvare <jdelvare@xxxxxxxx> >> Cc: linux-hwmon@xxxxxxxxxxxxxxx [...] >> +static u32 tja11xx_hwmon_in_config[] = { >> + HWMON_I_LCRIT_ALARM, >> + 0 >> +}; >> + >> +static const struct hwmon_channel_info tja11xx_hwmon_in = { >> + .type = hwmon_in, >> + .config = tja11xx_hwmon_in_config, >> +}; >> + >> +static u32 tja11xx_hwmon_temp_config[] = { >> + HWMON_T_CRIT_ALARM, >> + 0 >> +}; >> + >> +static const struct hwmon_channel_info tja11xx_hwmon_temp = { >> + .type = hwmon_temp, >> + .config = tja11xx_hwmon_temp_config, >> +}; >> + >> +static const struct hwmon_channel_info *tja11xx_hwmon_info[] = { >> + &tja11xx_hwmon_in, >> + &tja11xx_hwmon_temp, >> + NULL >> +}; >> + > You might want to consider using the new HWMON_CHANNEL_INFO() macro > to simplify above boilerplate code. Patch posted [...] -- Best regards, Marek Vasut