On 5/23/19 12:14 AM, Andrew Lunn wrote: > On Wed, May 22, 2019 at 11:48:06PM +0200, Marek Vasut wrote: >> On 5/18/19 4:14 PM, Andrew Lunn wrote: >>> On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote: >>>> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >>>> BroadRReach 100BaseT1 PHYs used in automotive. >>> >>> Hi Marek >>> >>>> + }, { >>>> + PHY_ID_MATCH_MODEL(PHY_ID_TJA1101), >>>> + .name = "NXP TJA1101", >>>> + .features = PHY_BASIC_T1_FEATURES, >>> >>> One thing i would like to do before this patch goes in is define >>> ETHTOOL_LINK_MODE_100baseT1_Full_BIT in ethtool.h, and use it here. >>> We could not do it earlier because were ran out of bits. But with >>> PHYLIB now using bitmaps, rather than u32, we can. >> >> So now that "[PATCH net-next 0/2] net: phy: T1 support" is posted, does >> this patch require any change ? I don't think it does ? > > Hi Marek > > In the end, no it does not need any changes because of my patchset. OK, thanks. -- Best regards, Marek Vasut