Guenter Roeck writes: >> + >> +#include <linux/kernel.h> >> +#include <linux/module.h> >> +#include <linux/init.h> >> +#include <linux/err.h> >> +#include <linux/i2c.h> > > Alphabetic include file order please. Sure >> + >> +static struct pmbus_driver_info ir3570b_info = { >> + .pages = 1, > > Either this ... > >> + .format[PSC_VOLTAGE_IN] = linear, >> + .format[PSC_VOLTAGE_OUT] = linear, >> + .format[PSC_CURRENT_IN] = linear, >> + .format[PSC_CURRENT_OUT] = linear, >> + .format[PSC_POWER] = linear, >> + .format[PSC_TEMPERATURE] = linear, >> + .func[0] = IR3570B_FUNCS, >> + .func[1] = IR3570B_FUNCS, > > ... or this is wrong. The latter is wrong. Thanks for catching it.