On Mon, Apr 15, 2019 at 02:47:16PM -0700, Nicolin Chen wrote: > Thanks for adding this. > > On Mon, Apr 15, 2019 at 01:27:12PM -0700, Guenter Roeck wrote: > > Add support for the new samples attributes to the hwmon core. > > > > Cc: Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx> > > Cc: Nicolin Chen <nicoleotsuka@xxxxxxxxx> > > Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx> > > Will redo my change and test through API later. > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > drivers/hwmon/hwmon.c | 5 +++++ > > include/linux/hwmon.h | 11 +++++++++++ > > 2 files changed, 16 insertions(+) > > > diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h > > index 7a8cc06a0d61..7b18a6150a11 100644 > > --- a/include/linux/hwmon.h > > +++ b/include/linux/hwmon.h > > @@ -40,6 +40,12 @@ enum hwmon_chip_attributes { > > hwmon_chip_register_tz, > > hwmon_chip_update_interval, > > hwmon_chip_alarms, > > + hwmon_chip_samples, > > + hwmon_chip_curr_samples, > > + hwmon_chip_in_samples, > > + hwmon_chip_power_samples, > > + hwmon_chip_temp_samples, > > + > > }; > > Why add a blank line at the end? No idea. I'll drop it. Thanks for having a look! Guenter