On Sun, Apr 14, 2019 at 11:59:38PM +0200, Krzysztof Adamski wrote: >PMBUS devices report values in real-world units. Those using direct >format require conversion using standarised coefficients and formula. >This operation is already done by pmbus_core and the default values for >coefficients are configured by chip drivers. > >However those default values are not allways suitable as they depend on >the value of sense register and environment used. For that reason, in >order to get values that make sense or just to get best accuracy, in it >may be required to tweak coefficient values. The proper values may be >measured during device production (to get best accuracy, they might be >callibrated for each individual unit) and stored as calibration values >in some place (like EEPROM or even a file). > >To support wide range of possible use cases, lets export those to user >space via sysfs attributes so that it can implement its own policies >about them. All those attributes are put into separate attribute_group >struct so that we can set its name to group all of them in a >"coefficients" subdirectory in sysfs. > >Signed-off-by: Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx> >--- >drivers/hwmon/pmbus/pmbus_core.c | 104 ++++++++++++++++++++++++++++++- >1 file changed, 102 insertions(+), 2 deletions(-) > [...] >+ pmbus_dev_attr_init(&ext_attr->attr, name, (S_IWUSR | S_IRUGO), I screwed up and did not fix this also, sorry for that. I'm not sending an updated version (yet) as I didn't get your approval for the concept itself (though I still hope you will reconsider taking into account my latest arguments). [...] > Krzysztof