On 4/9/19 5:56 AM, Michal Simek wrote:
Hi,
I have one question about hwmon/pmbus. I have tps544b25 on the board. I
have enabled this chip via DT to get probed. Patch below.
I can't see any issue with monitoring but I am curious how to enable
setting up voltage. I expect this should be moved to regulator folder or
better split done as MFD device.
I see there wm831x-hwmon and also wm8350-hwmon but nothing with pmbus
wiring.
Can you please suggest a way how this should be done?
Thanks,
Michal
commit 0aeba3b5a67eee06d3afe67c71e45a47e8e00f8d
Author: Michal Simek <michal.simek@xxxxxxxxxx>
AuthorDate: Mon Mar 4 13:51:05 2019 +0100
Commit: Michal Simek <michal.simek@xxxxxxxxxx>
CommitDate: Thu Mar 28 15:32:03 2019 +0100
hwmon: pmbus: Add DT wiring for ti,tps544b25
This should be enough for DT wiring to get generic functionality.
Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
diff --git a/drivers/hwmon/pmbus/pmbus.c b/drivers/hwmon/pmbus/pmbus.c
index 7718e58dbda5..be00cd144a2b 100644
--- a/drivers/hwmon/pmbus/pmbus.c
+++ b/drivers/hwmon/pmbus/pmbus.c
@@ -220,10 +220,17 @@ static int pmbus_probe(struct i2c_client *client,
MODULE_DEVICE_TABLE(i2c, pmbus_id);
+static const struct of_device_id pmbus_of_match[] = {
+ {.compatible = "ti,tps544b25"},
+ {}
+};
+MODULE_DEVICE_TABLE(of, pmbus_of_match);
+
/* This is the driver that will be inserted */
static struct i2c_driver pmbus_driver = {
.driver = {
.name = "pmbus",
+ .of_match_table = of_match_ptr(pmbus_of_match),
},
.probe = pmbus_probe,
.remove = pmbus_do_remove,
