Hi Sudeep, There are a couple of things on which I would appreciate your feedback regarding the Linux SCMI sensor protocol: 1) The Linux SCMI implementation has all the nuts and bolts to allow configuring trip points, but the hwmon subsystem through the use of hwmon_thermal_add_sensor() API does not actually make use of that capability. Would it be a big stretch to use the hwmon_ops::write function to get to support that feature? The other thing that puzzles me is that there does not appear to be provision in the SCMI sensor protocol to describe thermal zones, so I assume that people still have to provide supplemental data through Device Tree for devm_thermal_zone_of_sensor_register() to pick up the thermal zones definitions? 2) Support for regulators through SCMI I work with a device where the regulators can only be controlled via a dedicated piece of HW which is accessible through SCMI from the Linux side. Do you think there is value in coming up with a scmi-regulator.c driver that makes use of the sensor protocol for discovering and reporting regulators or would that be something that belongs more to the power domain protocol? Thanks for reading me! Cheers -- Florian
