On Fri, Mar 29, 2019 at 4:22 AM Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Mar 28, 2019 at 12:46:15PM -0500, Rob Herring wrote:
> > On Thu, Mar 28, 2019 at 01:09:36PM +0000, Charles Keepax wrote:
> > > Lochnagar is an evaluation and development board for Cirrus
> > > Logic Smart CODEC and Amp devices. It allows the connection of
> > > most Cirrus Logic devices on mini-cards, as well as allowing
> > > connection of various application processor systems to provide a
> > > full evaluation platform. This driver supports the board
> > > controller chip on the Lochnagar board.
> > >
> > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > > +Required properties:
> > > +
> > > + - compatible : One of the following strings:
> > > + "cirrus,lochnagar2-hwmon"
> > > +
> > > +Example:
> > > +
> > > +lochnagar-hwmon {
> > > + compatible = "cirrus,lochnagar2-hwmon";
> >
> > You don't have any resources in DT, the parent MFD driver can just
> > instantiate this child device.
> >
>
> + Lee Jones
>
> Lee, was very very keen for me to not mix mfd_add_devices and
> of_platform_populate in the MFD driver. As such we moved all the
> sub-drivers into DT. I agree it is a little odd that this exists
> only to bind in this driver but I think it is probably a bit late
> to change that. If we were going to have the MFD instantiating
> children directly a lot of the rest of the binding would have
> been done very differently.
Okay. This is why I don't like incomplete examples...
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
