Re: [PATCH] dt-bindings: hwmon (pwm-fan) Remove dead "cooling-*-state" properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ +Arnd, Olof ]

On 19/03/2019 15:06, Krzysztof Kozlowski wrote:
On Tue, 19 Mar 2019 at 15:54, Robin Murphy <robin.murphy@xxxxxxx> wrote:

The old "cooling-{min,max}-state" properties for thermal bindings were
ratified to "cooling-{min,max}-level" by commit eb168b70dea5 ("of:
thermal: Fix inconsitency between cooling-*-state and cooling-*-level"),
which were later removed entirely by commit e04907dbc259 ("dt-bindings:
thermal: Remove "cooling-{min|max}-level" properties").

The pwm-fan binding, however, was apparently in-flight in parallel with
that ratification, and so managed to introduce an example of the old
properties which escaped the scope of the later cleanup and has thus
continued to be dutifully copied for new boards despite being useless.
Clean up these remaining undocumented anachronisms to minimise any
further confusion.

Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
---

Presented as one big hwmon patch for simplicity, but the DT changes
can quite easily be broken out by platform if maintainers prefer.

Robin.

  Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 --
  arch/arm/boot/dts/exynos4412-odroidu3.dts           | 2 --
  arch/arm/boot/dts/exynos5410-odroidxu.dts           | 2 --
  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi  | 2 --

Probably you should send it directly to arm-soc maintainers so it
would go with other DT changes. In such case:
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Indeed, it had crossed my mind that routing this through arm-soc might make sense - Arnd, Olof, would you agree? And if so, should I resend to the arm-soc alias or might you be able to pick it directly?

Thanks to everyone for the acks!

Robin.


Best regards,
Krzysztof

  arch/arm/boot/dts/imx6qdl-emcon.dtsi                | 2 --
  arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts  | 2 --
  arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi       | 2 --
  arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi       | 2 --
  8 files changed, 16 deletions(-)




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux