Re: [PATCH 2/2] hwmon: (ntc_thermistor): add support for B57891S0103 from Epcos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/20/18 10:06 PM, Peter Rosin wrote:
On 2018-11-19 22:28, Guenter Roeck wrote:
On Mon, Nov 19, 2018 at 09:16:12PM +0000, Peter Rosin wrote:

Guess I deserve the non-alphabetic order as penalty for not enforcing it
earlier. I'll accept the patch after DT approval and submit another one
myself afterwards to restore alphabetic order.

Right, I'm thinking another good change would be to introduce an enum
into the ntc_thermistor_id array, because the hard-coded numbering in

Yes, sounds like a good idea.

the ntc_match variable is a bit fragile in my taste, and that list would
also benefit from being alphabetic. Currently there's simply no way to
add things in the middle without causing mayhem. I thought about doing
that, but didn't want to waste energy doing it up front without knowing
if it would be well received (the driver might have been superseded or

It would.

Right, so I have some patches sorting things out... However, one question

Sounds good.

before I send them: Is it ok to sort the enum ntc_thermistor_type in the
include/linux/platform_data/ntc_thermistor.h header or will that break
stuff?


Should be ok. It is not an UAPI, after all.

Guenter

Cheers,
Peter

Guenter

something). I'm glad that you have volunteered to clean things up.
Ha! :-)

Cheers,
Peter

Guenter

  };
struct ntc_thermistor_platform_data {
--
2.11.0







[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux