On Sat, Oct 27, 2018 at 12:30:59AM +0200, Rasmus Villemoes wrote:
> struct attribute::name which this local variable name is eventually
> assigned to is "const char*", and so is the template parameter. We might
> as well preserve the constness all the way through.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Applied to hwmon-next.
Note that the "drivers:" tag is unnecessary; I removed it when applying
the patch.
Guenter
> ---
> drivers/hwmon/hwmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
> index 975c95169884..ea42c5ec40d9 100644
> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -267,7 +267,7 @@ static struct attribute *hwmon_genattr(struct device *dev,
> struct device_attribute *dattr;
> struct attribute *a;
> umode_t mode;
> - char *name;
> + const char *name;
> bool is_string = is_string_attr(type, attr);
>
> /* The attribute is invisible if there is no template string */
> @@ -289,7 +289,7 @@ static struct attribute *hwmon_genattr(struct device *dev,
> return ERR_PTR(-ENOMEM);
>
> if (type == hwmon_chip) {
> - name = (char *)template;
> + name = template;
> } else {
> scnprintf(hattr->name, sizeof(hattr->name), template,
> index + hwmon_attr_base(type));
