Hi Christian, thanks a lot for your feedback! On Tue, Oct 16, 2018 at 7:36 AM Christian Franke <Christian.Franke@xxxxxxxxxxx> wrote: > Linus Walleij wrote: > > ... > > - I am uncertain if this applies to SAS drives as well, > > it appears not (Christian Frankes answer) they > > require a different access method, and I can't test it, > > so I am currently only setting it up explicitly for > > ATA slave devices. > > It doesn't apply to SAS devices. > > If there is ATA/SATA temperature detection support in the kernel, it > should IMO also be mapped to SCSI/SAS commands as suggested by SAT (see > also the mail from Douglas Gilbert): > If SCSI Temperature Log page is requested (SCSI LOG SENSE cmd) for an > ATA/SATA device, read SMART attributes and return a Log page with > Temperature field set from attribute 194. > > Does your patch support this? Not yet. I have nothing to test with, else I would try to take a stab. I try to start by fixing the small need I have but leave space and placeholders for improvements. > SAT requires "SCT Status" or "Device Statistics" access method for > temperature. In practice, SMART attribute 194 is supported by much more > devices. If something like this is used by USB attached drives I could try it, because I do have a USB cradle. Yours, Linus Walleij