Reading from the MC13892 ADC channels causes shutdown

[Fabio Estevam <festevam@xxxxxxxxx>]

Hi,

Has anyone managed to read ADC values from the MC13892 ADC recently?

I am running 4.19-rc1 on a imx51-babbage board and after trying to
read a channel:

# cat /sys/class/hwmon/hwmon0/device/in7_input

the PMIC shuts down completely, which causes the entire board to die.

I don't know if this is a regression or not. I can try to run a
bisect, but I would be interested to know if anyone knows if MC13892
ADC readings worked at some point in the past.

Also noticed that the shutdow happens after writing to the ADC1 register.

Removing the line below  makes the ADC reading to timeout, but at
least the PMIC does not shut down:

--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -327,7 +327,6 @@ int mc13xxx_adc_do_conversion(struct mc13xxx
*mc13xxx, unsigned int mode,
                        mc13xxx_handler_adcdone, __func__, &adcdone_data);

        mc13xxx_reg_write(mc13xxx, MC13XXX_ADC0, adc0);
-       mc13xxx_reg_write(mc13xxx, MC13XXX_ADC1, adc1);

        mc13xxx_unlock(mc13xxx);

Any ideas are welcome.

Thanks,

Fabio Estevam