On Sun, Oct 8, 2017 at 4:39 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> @@ -86,9 +84,9 @@ static ssize_t fan1_alarm_show(struct device *dev, >> struct device_attribute *attr, char *buf) >> { >> struct gpio_fan_data *fan_data = dev_get_drvdata(dev); >> - int value = gpio_get_value_cansleep(fan_data->alarm_gpio); >> + int value = gpiod_get_value_cansleep(fan_data->alarm_gpio); >> >> - if (fan_data->alarm_gpio_active_low) >> + if (gpiod_is_active_low(fan_data->alarm_gpio)) > > Is this still needed ? Just wondering - I would have thought that > gpiod_get_value_cansleep() does the conversion. My bad. Fixing in V2, sending it soon. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html