On Sun, 10 Sep 2017 16:05:28 +0200 Davide Hug <d@xxxxxxxxxx> wrote: > On Sun, 10 Sep 2017 11:44:46 +0200 > Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > After finding out there are active users of this sensor I noticed: > > I would like to point out that I'm doing this for learning purposes and that I > don't have any pressing needs for this driver to work. But of course I'm really > grateful for all the replays! > I can't claim I ever had any real use for this part either. It was just looking at me from a dev board and asking for me to mainline the driver :) > > Cc: arm@xxxxxxxxxx > > Cc: Marco Franchi <marco.franchi@xxxxxxx> > > Cc: Davide Hug <d@xxxxxxxxxx> > > Cc: Jonathan Cameron <jic23@xxxxxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > ChangeLog v1->v2: > > - Fix the return value from devm_gpiod_get() with PTR_ERR() > > so we defer etc correctly. > > > > ARM SoC folks: please ACK this so the HWMON maintainer can merge > > it when it is in reasonable shape. > > > > Marco: can you test this patch with your setup? > > > > Davide: can you test this patch with your setup? > > I tested it and I can make it work (as the current driver) by modifying gpiolib > to not test for the FLAG_USED_AS_IRQ in _gpiod_direction_output_raw. > Otherwise again I get: > > gpio-48 (SHT15 data): _gpiod_direction_output_raw: tried to set a GPIO tied to an IRQ as output > > as with the current driver. But I guess this is as expected. > (I did this on a beaglebone black with kernel 4.9.10. I'll compile a newer > kernel and try it there to.) Cool. > > Thanks! Thanks to you. It's always nice when people fix issues with / update a driver you've ignored for perhaps 8 years ;) As you know this particular part has a truely horrendous custom bus. I'm always amazed these old sensiron parts work at all. I'm also really surprised to see they are still readily available. Jonathan > Davide -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
