On Fri, Sep 8, 2017 at 7:37 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> /* Try requesting the GPIOs */
> - ret = devm_gpio_request_one(&pdev->dev, data->pdata->gpio_sck,
> - GPIOF_OUT_INIT_LOW, "SHT15 sck");
> - if (ret) {
> + data->sck = devm_gpiod_get(&pdev->dev, "clk", GPIOD_OUT_LOW);
> + if (IS_ERR(data->sck)) {
> dev_err(&pdev->dev, "clock line GPIO request failed\n");
Missed to update ret here:
ret = PTR_ERR(data->sck);
> goto err_release_reg;
> }
> -
> - ret = devm_gpio_request(&pdev->dev, data->pdata->gpio_data,
> - "SHT15 data");
> - if (ret) {
> + data->data = devm_gpiod_get(&pdev->dev, "data", GPIOD_IN);
> + if (IS_ERR(data->data)) {
> dev_err(&pdev->dev, "data line GPIO request failed\n");
Missed to update ret here:
ret = PTR_ERR(data->sck);
If you send a v2, please add Marco Franchi on Cc as he has hardware to
test this driver with dt support.
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
