On 06/23/2017 08:39 PM, Patrick Venture wrote:
Reduce the fan_tach period such that the fan controller uses a shorter
period to measure the rpm.
This explains what you are doing, but not why. What is the problem you are
trying to solve, and why doesn't it create other problems ? Presumably there
was a reason for the larger period used earlier. If not, if it was just a
conservative setting, here is the place to say it.
I'd update the information myself, but I don't think the underlying specification
is public, or at least I did not find it.
Guenter
Testing: Tested on an ast2400 sitting on a quanta-q71l.
Signed-off-by: Patrick Venture <venture@xxxxxxxxxx>
---
v3: Added missing change log
v2: Updated commit message language
---
drivers/hwmon/aspeed-pwm-tacho.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
index 86e2ea8287a7..b2ab5612d8a4 100644
--- a/drivers/hwmon/aspeed-pwm-tacho.c
+++ b/drivers/hwmon/aspeed-pwm-tacho.c
@@ -160,7 +160,7 @@
* 11: reserved.
*/
#define M_TACH_MODE 0x02 /* 10b */
-#define M_TACH_UNIT 0x1000
+#define M_TACH_UNIT 0x00c0
#define INIT_FAN_CTRL 0xFF
struct aspeed_pwm_tacho_data {
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
