Re: [PATCH 1/2 v2] hwmon: (aspeed-pwm-tacho) reduce fan_tach period

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 23, 2017 at 08:05:25AM -0700, Patrick Venture wrote:
> Reduce the fan_tach period such that the fan controller uses a shorter
> period to measure the rpm.
> 
> Testing: Tested on an ast2400 sitting on a quanta-q71l.
> 
> Signed-off-by: Patrick Venture <venture@xxxxxxxxxx>

Please provide change logs, and keep version numbers consistent
for a series even if one patch doesn't change.

Now I'll have to go back, find the flurry of older versions, and try
to find out what changed and why. This takes time which I don't have.
I'll probably only get to this after the next commit window, sorry.

Guenter

> ---
>  drivers/hwmon/aspeed-pwm-tacho.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 86e2ea8287a7..b2ab5612d8a4 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -160,7 +160,7 @@
>   * 11: reserved.
>   */
>  #define M_TACH_MODE 0x02 /* 10b */
> -#define M_TACH_UNIT 0x1000
> +#define M_TACH_UNIT 0x00c0
>  #define INIT_FAN_CTRL 0xFF
>  
>  struct aspeed_pwm_tacho_data {
> -- 
> 2.13.1.611.g7e3b11ae1-goog
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux