On 16.06.2017 18:41, Guenter Roeck wrote: > On Fri, Jun 16, 2017 at 11:02:31AM +0200, Florian Echtler wrote: >> This patch exports the SMC key access functions from applesmc.c to allow >> access from other drivers, in particular, the yet-to-be-written ACPI >> driver for Target Display Mode (TDM). > > It is structurally deficient to have the hwmon driver export those functions. > If used by another driver, the functions should be moved to a common > driver, possibly in mfd. This driver would then also be responsible to > instantiate its child drivers. Hm, this sounds like a major rework? AFAICT, that would roughly mean to move all code up to, but not including, applesmc_calibrate to mfd and leave the rest in hwmon? What's the mechanism to auto-load another kernel module? Best, Florian -- SENT FROM MY DEC VT50 TERMINAL
Attachment:
signature.asc
Description: OpenPGP digital signature
