On 04/27/2017 09:34 PM, Samuel Mendoza-Jonas wrote:
On Wed, 2017-04-26 at 11:03 +1000, Samuel Mendoza-Jonas wrote:
On Fri, 2017-04-21 at 06:49 -0700, Guenter Roeck wrote:
On 04/20/2017 09:25 PM, Samuel Mendoza-Jonas wrote:
IR35221 is a Digital DC-DC Multiphase Converter
Signed-off-by: Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>
---
- Tested on a ppc64 system which includes several of these devices.
- This patch re-implements the linear reg2data/data2reg functions from
pmbus-core like some other drivers in order to scale some results. Is
this something that would be better off being made generic for pmbus
drivers to call?
That might make sense. The only other driver is zl6100, or am I missing
something ?
I believe ltc2978 has a small implementation as well.
Trying to understand the code, the data format seems to be linear11 with
an added exponent on top of it. Is that correct ? If so, I wonder if we should
make that configurable, ie store the additional exponent in R and handle it
in the pmbus core. Would that help ?
Yes that's essentially what it is. Using R for the extra exponent would
be a neat solution, however at least for this chip commands in the same
class have different scaling exponents (eg VIN_UV_WARN_LIMIT vs
READ_VIN). I'll have a look though and see if I can cover this - maybe a
small wrapper function that updates the exponent in the data returned by
pmbus_read_word_data()/etc?
After thinking about this for a bit I don't think it's as straightforward
as I would like :)
Hm ... lets drop this for now; we can always revisit it later. Can you address
the other comments and resubmit ?
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
