On Tue, 21 Feb 2017 07:42:58 -0800, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>> - superio_enter(sio_data->sioreg);
>> + if (superio_enter(sio_data->sioreg)) {
>> + pr_err("%s: superio is busy!!\n", __func__);
>> + return;
>> + }
>
> This is not good. It effectively ignores the error and does not
> initialize the chip's fan configuration. Displaying a log message
> doesn't improve the situation.
>
> The best solution here would probably be to remove superio_enter/exit
> from this function and move the superio_exit() call in the calling code
> after the call to w83627ehf_check_fan_inputs().
Thank you. I agree with your solution. I will post an updated patch.
---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
