On 01/26/2017 06:17 AM, Andrea Merello wrote:
This patch adds a HWMON driver for ST Microelectronics STTS751 temperature sensors. Changes since V3: - fix sysfs_notify() filename - simplify error exit path in stts751_update_temp(): kill useless goto - fix set function were racy due to lock incorrectly placed - use msecs_to_jiffies instead of manual calculation - fix jiffies and msecs were mixed up - don't mark cache as good unless reads really succeded to fill up it - when updating therm, hyst keeps relative value rather than abs value - don't should in dev_dbg when chip is detected - don't ever generate two uevents - clarify clear-on-read behaviour of status reg alarm flags - simplify mDEG to HW conversion function - fix chip stops due to incorrect resolution configuration - fix incorrectly reading negative numbers from HW Thanks-to: LABBE Corentin [for suggestions] Signed-off-by: Andrea Merello <andrea.merello@xxxxxxxxx> Cc: LABBE Corentin <clabbe.montjoie@xxxxxxxxx> Cc: Guenter Roeck <linux@xxxxxxxxxxxx> Cc: Jean Delvare <jdelvare@xxxxxxxx>
[ ... ]
+ +static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_input, NULL, 0); +static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_min, set_min, 0); +static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_max, set_max, 0); +static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_min_alarm, NULL, 0); +static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_max_alarm, NULL, 0); +static SENSOR_DEVICE_ATTR(temp1_crit, S_IWUSR | S_IRUGO, show_therm, + set_therm, 0); +static SENSOR_DEVICE_ATTR(temp1_crit_hyst, S_IWUSR | S_IRUGO, show_hyst, + set_hyst, 0); +static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_therm_trip, NULL, 0); +static SENSOR_DEVICE_ATTR(update_interval, S_IWUSR | S_IRUGO, + show_interval, set_interval, 0);
I forgot to mention: Symbolic permissions ran out of favor upstream. Please use octals above to make the annoying checkpatch warnings go away. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
