On Fri, 9 Dec 2016 06:22:43 -0800, Guenter Roeck wrote: > On 12/09/2016 01:49 AM, Jean Delvare wrote: > > Looking at function nct7802_write_fan_min() I think an overflow can > > happen here too, as DIV_ROUND_CLOSEST() is called before clamp_val(). > > Any reason why you did not fix that one? > > > Not really. The call is > DIV_ROUND_CLOSEST(1350000U, limit); > and thus won't overflow. Limit is originally parsed by kstrtoul into an unsigned long, however the nct7802_write_fan_min function parameter is an unsigned int, so it is implicitly cast to an unsigned int. On a 32-bit system, that may not fit? -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
