On Tue, Aug 02, 2016 at 06:52:21PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> > --- > drivers/hwmon/fschmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c > index d58abdc..a7e4885 100644 > --- a/drivers/hwmon/fschmd.c > +++ b/drivers/hwmon/fschmd.c > @@ -602,7 +602,7 @@ static ssize_t store_alert_led(struct device *dev, > return count; > } > > -static DEVICE_ATTR(alert_led, 0644, show_alert_led, store_alert_led); > +static DEVICE_ATTR(alert_led, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_alert_led, store_alert_led); Use DEVICE_ATTR_RW() please. -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
