Hi Geert, Thank you for the review. On Wed, May 22, 2024 at 2:14 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Tue, Apr 23, 2024 at 7:59 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add support to configure bias-disable, bias-pull-up and bias-pull-down > > properties of the pin. > > > > Two new function pointers get_bias_param() and get_bias_val() are > > introduced as the values in PUPD register differ when compared to > > RZ/G2L family and RZ/V2H(P) SoC, > > > > Value | RZ/G2L | RZ/V2H > > --------------------------------- > > 00b: | Bias Disabled | Pull up/down disabled > > 01b: | Pull-up | Pull up/down disabled > > 10b: | Pull-down | Pull-down > > 11b: | Prohibited | Pull-up > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > RFC->v2 > > - New patch > > Thanks for your patch! > > > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > > @@ -1139,6 +1175,25 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev, > > arg = rzg2l_read_pin_config(pctrl, SR(off), bit, SR_MASK); > > break; > > > > + case PIN_CONFIG_BIAS_DISABLE: > > + case PIN_CONFIG_BIAS_PULL_UP: > > + case PIN_CONFIG_BIAS_PULL_DOWN: { > > + if (!(cfg & PIN_CFG_PUPD)) > > + return -EINVAL; > > + > > + ret = pctrl->data->get_bias_param(rzg2l_read_pin_config(pctrl, > > + PUPD(off), > > + bit, PUPD_MASK)); > > This is rather long, so please split it in two parts, like is done in > other cases in this function: > > arg = rzg2l_read_pin_config(pctrl, PUPD(off), bit, PUPD_MASK); > ret = pctrl->data->get_bias_param(arg); > Agreed, I'll update it as per your suggestion. Cheers, Prabhakar