Re: [PATCH libgpiod v3 0/4] tools: tests: fix a few issues in bash scripts

[Kent Gibson <warthog618@xxxxxxxxx>]

On Tue, May 28, 2024 at 10:25:47AM +0200, Bartosz Golaszewski wrote:
> Fix a few issues with tools tests reported by Andy.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

> ---
> Changes in v3:
> - Use $* in the message string in assert_fail()
> - Make shellcheck happy when using find exclusively instead of find + grep
> - Link to v2: https://lore.kernel.org/r/20240527-fix-bash-tests-v2-0-05d90cea24cd@xxxxxxxxxx
>
> Changes in v2:
> - Use double quotes around $@ to prevent globbing but allow variable expansion
> - Link to v1: https://lore.kernel.org/r/20240524-fix-bash-tests-v1-0-1397c73073a6@xxxxxxxxxx
>
> ---
> Bartosz Golaszewski (4):
>       tools: tests: use tabs for indentation consistently
>       tools: tests: use "$@" instead of $*
>       tools: tests: remove unneeded ';' in while loops
>       tools: tests: remove dependency on grep
>
>  tools/gpio-tools-test.bash | 46 ++++++++++++++++++----------------------------
>  1 file changed, 18 insertions(+), 28 deletions(-)
> ---
> base-commit: 27fe10150f6d5fa78d1a1ef1e922dc8395d1154d
> change-id: 20240524-fix-bash-tests-545bf26447b3
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>