Re: [PATCH 01/13] a2b: add A2B driver core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/drivers/a2b/a2b.c
> @@ -0,0 +1,1252 @@
…
> +#define __a2b_bus_for_each_node(__bus, __node, __i) \
> +	for (__i = 0; __i < A2B_MAX_NODES && (__node = __bus->nodes[__i]); i++)
…

I suggest to reconsider the usage of double underscores for identifiers.
How do you think about to avoid that this software depends on undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux