On Thu, May 16, 2024 at 10:55:40PM +0800, Kent Gibson wrote: > On Thu, May 16, 2024 at 12:57:42PM +0000, Hagar Hemdan wrote: > > On Tue, May 14, 2024 at 08:42:21PM +0800, Kent Gibson wrote: > > Now I need to test your patch to see what it actually does. > Tested. Fails. It does what I thought it would - clamps the offset into bounds BEFORE the call to gpio_device_get_desc(). The appropriate place for this fix is in gpio_device_get_desc(), after the bounds check. Cheers, Kent.
Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- From: Kent Gibson <warthog618@xxxxxxxxx>
- Date: Fri, 17 May 2024 00:22:39 +0800
- In-reply-to: <20240516145540.GA116534@rigel>
- References: <20240514122601.15261-1-hagarhem@amazon.com> <20240514124221.GA76024@rigel> <20240516125742.GA14240@amazon.com> <20240516145540.GA116534@rigel>
- Follow-Ups:
- References:
- [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- From: Hagar Hemdan
- Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- From: Kent Gibson
- Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- From: Hagar Hemdan
- Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- From: Kent Gibson
- [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- Prev by Date: Re: [PATCH v1 1/1] gpio: Remove legacy API documentation
- Next by Date: Re: [PATCH] pinctrl: cy8c95x0: Cache muxed registers
- Previous by thread: Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- Next by thread: Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
- Index(es):
 |