Re: [PATCH v2] gpio: Add Intel Granite Rapids-D vGPIO driver

[Andy Shevchenko <andy@xxxxxxxxxx>]

On Tue, Apr 23, 2024 at 09:13:14PM +0300, Aapo Vienamo wrote:
> This driver provides a basic GPIO driver for the Intel Granite Rapids-D
> virtual GPIOs. On SoCs with limited physical pins on the package, the
> physical pins controlled by this driver would be exposed on an external
> device such as a BMC or CPLD. The virtual GPIO registers are an
> interface to firmware, which communicates with the external device that
> implements the GPIO hardware functionality.

...

> +#include <linux/bitmap.h>
> +#include <linux/bits.h>

The latter is guaranteed to be included by the former. I can amend this when
applying.

...

I'll wait for others to review for a while. I want to send my PR to Bart at
the end of this week.

-- 
With Best Regards,
Andy Shevchenko