Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH0108 and PMD8028 support

[Rob Herring <robh+dt@xxxxxxxxxx>]

On Tue, Mar 26, 2024 at 5:07 PM Anjelique Melendez
<quic_amelende@xxxxxxxxxxx> wrote:
>
> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
> to include compatible strings for PMIH0108 and PMD8028 PMICs.

You didn't test this with dtbs_check:

     47  gpio@c000: gpio-line-names: ['AP_SUSPEND', '', '', '', '',
'', '', '', '', '', '', ''] is too short
     10  gpio@8800: gpio-line-names: ['FLASH_STROBE_1', 'AP_SUSPEND',
'PM8008_1_RST_N', '', '', '', 'PMIC_EDP_BL_EN', 'PMIC_EDP_BL_PWM', '']
is too short

>
> Signed-off-by: Anjelique Melendez <quic_amelende@xxxxxxxxxxx>
> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 2b17d244f051..a786357ed1af 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -57,10 +57,12 @@ properties:
>            - qcom,pma8084-gpio
>            - qcom,pmc8180-gpio
>            - qcom,pmc8180c-gpio
> +          - qcom,pmd8028-gpio
>            - qcom,pmi632-gpio
>            - qcom,pmi8950-gpio
>            - qcom,pmi8994-gpio
>            - qcom,pmi8998-gpio
> +          - qcom,pmih0108-gpio
>            - qcom,pmk8350-gpio
>            - qcom,pmk8550-gpio
>            - qcom,pmm8155au-gpio
> @@ -143,6 +145,7 @@ allOf:
>                - qcom,pm8005-gpio
>                - qcom,pm8450-gpio
>                - qcom,pm8916-gpio
> +              - qcom,pmd8028-gpio
>                - qcom,pmk8350-gpio
>                - qcom,pmr735a-gpio
>                - qcom,pmr735b-gpio
> @@ -304,6 +307,21 @@ allOf:
>            minItems: 1
>            maxItems: 7
>
> +  - if:
> +      properties:
> +        comptaible:

It took me a bit to find, but you've got a typo here. The result is
this "if" schema is always true unless you actually have an instance
with the typo too. Please send a fix.

> +          contains:
> +            enum:
> +              - qcom,pmih0108-gpio
> +    then:
> +      properties:
> +        gpio-line-names:
> +          minItems: 18
> +          maxItems: 18
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 9