Re: [libgpiod][PATCH 1/2] build: fix configure error messages on missing functions

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Apr 9, 2024 at 11:33 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Fix three incorrect messages that report missing library functions as
> required to build the core library when they are actually needed to build
> the gpio-tools.
>
> Fixes: 9e69d7552cf2 ("configure: improve the header and library function checks")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>  configure.ac | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 04787d4..3b5bbf2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -117,9 +117,9 @@ AM_CONDITIONAL([WITH_GPIOSET_INTERACTIVE],
>  AS_IF([test "x$with_tools" = xtrue],
>         [# These are only needed to build tools
>         AC_CHECK_FUNC([daemon], [], [FUNC_NOT_FOUND_TOOLS([daemon])])
> -       AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])])
> -       AC_CHECK_FUNC([scandir], [], [FUNC_NOT_FOUND_LIB([scandir])])
> -       AC_CHECK_FUNC([versionsort], [], [FUNC_NOT_FOUND_LIB([versionsort])])
> +       AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_TOOLS([asprintf])])
> +       AC_CHECK_FUNC([scandir], [], [FUNC_NOT_FOUND_TOOLS([scandir])])
> +       AC_CHECK_FUNC([versionsort], [], [FUNC_NOT_FOUND_TOOLS([versionsort])])
>         AS_IF([test "x$with_gpioset_interactive" = xtrue],
>                 [PKG_CHECK_MODULES([LIBEDIT], [libedit >= 3.1])])
>         ])
> --
> 2.40.1
>

This is non-controversial, so I applied it.

Bart