Re: [PATCH 1/6] mmc: core: Add mmc_gpiod_set_cd_config() function

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 4/8/24 5:23 PM, Andy Shevchenko wrote:
> On Sun, Apr 07, 2024 at 10:04:48PM +0200, Hans de Goede wrote:
>> Some mmc host drivers may need to fixup a card-detection GPIO's config
>> to e.g. enable the GPIO controllers builtin pull-up resistor on devices
>> where the firmware description of the GPIO is broken (e.g. GpioInt with
>> PullNone instead of PullUp in ACPI DSDT).
>>
>> Since this is the exception rather then the rule adding a config
>> parameter to mmc_gpiod_request_cd() seems undesirable, so instead
>> add a new mmc_gpiod_set_cd_config() function. This is simply a wrapper
>> to call gpiod_set_config() on the card-detect GPIO acquired through
>> mmc_gpiod_request_cd().
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

for just this patch or for the series ?

> assuming you considered addressing nit-picks.

Ack will do.

Regards,

Hans