On 14/03/2024 21:04, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@xxxxxxxxxxx> > > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to inclde compatible strings for PMXR2230 and PM6450 PMICs. Typo, include Two commits and quite different subjects... Please make it somehow consistent. Prefix is qcom,pmic-gpio, not qcom-pmic-gpio. Start either with capital or lower case - just choose one pattern. A nit, subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
Re: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding
- From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
- Date: Thu, 14 Mar 2024 22:19:45 +0100
- In-reply-to: <20240314200419.4733-4-quic_amelende@quicinc.com>
- References: <20240314200419.4733-2-quic_amelende@quicinc.com> <20240314200419.4733-4-quic_amelende@quicinc.com>
- User-agent: Mozilla Thunderbird
- References:
- [PATCH 0/5] Add GPIO support for various PMICs
- From: Anjelique Melendez
- [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding
- From: Anjelique Melendez
- [PATCH 0/5] Add GPIO support for various PMICs
- Prev by Date: [PATCH 5/5] pinctrl: qcom: spmi-gpio: Add support for pmih010x and pmd802x
- Next by Date: Re: [PATCH 2/5] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH010x and PMD802x binding
- Previous by thread: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding
- Next by thread: [PATCH 2/5] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH010x and PMD802x binding
- Index(es):
 |