Hi Linus, Sorry for late reply. > Subject: Re: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type > > On Fri, Feb 23, 2024 at 8:07 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> > wrote: > > > From: Peng Fan <peng.fan@xxxxxxx> > > > > i.MX95 System Manager FW supports SCMI PINCTRL protocol, but uses > OEM > > Pin Configuration type, so extend the driver to support custom params. > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > I can't really say much about this as pinctrl maintainer other than that it > makes me a bit unhappy that i.MX95 is not using the "default" > SCMI pinctrl bindings. Sorry about that. I check with our SCMI firmware owner, we could not afford the memory size, it would require a massive amount of data in arrays to match pins with functions and then figure out the mux value for that pin > > If the spec allows for this, and NXP Freescale is using it, I will just have to > accept it. In the spec, Table 24 Pin Configuration Type and Enumerations, 192 -255 is for OEM specific units > > It feels like that's the old NXP Freescale pin controller living on just hidden > behind SCMI, so potentially it should also share code with the old i.MX pin > controller driver. But I think you wrote part of that driver so you would be the > best to ask about that in any case I think? The scmi imx extension code not able to share code with the non-scmi code, The scmi protocol requires config type and config value, so we need new way to pack the data. Thanks, Peng. > > Yours, > Linus Walleij