The AW9523 driver fails to build in some allmod configs since the I2C core can be a module, but AW9523 can not. Fix it up by allowing AW9523 to be a module (tristate). Fixes: a4f15a8d4c82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander") Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Reported-by: kernel test robot <lkp@xxxxxxxxx> Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@xxxxxxxxx/ Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> --- Changes in v2: - Instead of restricting to bool and I2C=y, just allow the driver to be tristate (which was probably the intention). - Link to v1: https://lore.kernel.org/r/20240305-fix-aw9523-v1-1-97205563645b@xxxxxxxxxx --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 21d38bf2d1ca..d45657aa986a 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -128,7 +128,7 @@ config PINCTRL_AXP209 Say Y to enable pinctrl and GPIO support for the AXP209 PMIC. config PINCTRL_AW9523 - bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" + tristate "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" depends on OF && I2C select PINMUX select PINCONF --- base-commit: a4f15a8d4c8253d44830731d99be869d273c0c82 change-id: 20240305-fix-aw9523-4006b88f7b55 Best regards, -- Linus Walleij <linus.walleij@xxxxxxxxxx>