Re: [PATCH] pinctrl: aw9523: Fix I2C=y dependency

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Linus,

On Tue, Mar 5, 2024 at 11:29 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> The AW9523 driver fails to build in some allmod configs since the
> I2C core can be a module, but AW9523 can not. Fix it up so we depend
> on I2C being compiled-in.
>
> Fixes: a4f15a8d4c82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@xxxxxxxxx/
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -129,7 +129,7 @@ config PINCTRL_AXP209
>
>  config PINCTRL_AW9523
>         bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver"
> -       depends on OF && I2C
> +       depends on OF && I2C=y
>         select PINMUX
>         select PINCONF
>         select GENERIC_PINCONF

Any reason PINCTRL_AW9523 cannot be tristate?
The driver goes to great lengths to support removal.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds