On Mon, Mar 4, 2024 at 5:03 PM Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > swnode_get_gpio_device() can return an error pointer, however > gpio_device_put() is not able to accept error values. Thus using > __free() will result in dereferencing an invalid pointer. > Can you post the steps to reproduce this? Because it should work[1]. Bart [1] https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/driver.h#L616
Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- From: Bartosz Golaszewski <brgl@xxxxxxxx>
- Date: Mon, 4 Mar 2024 17:34:27 +0100
- In-reply-to: <20240304160320.1054811-1-ckeepax@opensource.cirrus.com>
- References: <20240304160320.1054811-1-ckeepax@opensource.cirrus.com>
- Follow-Ups:
- Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- From: Charles Keepax
- Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- References:
- [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- From: Charles Keepax
- [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- Prev by Date: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- Next by Date: Re: [PATCH v1 1/1] gpiolib: Deduplicate cleanup for-loop in gpiochip_add_data_with_key()
- Previous by thread: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- Next by thread: Re: [PATCH] gpio: swnode: Don't use __free() on result of swnode_get_gpio_device()
- Index(es):
 |