Re: [PATCH v7] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Mar 1, 2024 at 10:34 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:


> > +static const struct of_device_id of_aw9523_i2c_match[] = {
> > +     { .compatible = "awinic,aw9523-pinctrl", },
>
> That's an undocumented compatible, which we cannot take. You need bindings.

There is a binding, I just merged it yesterday but that's not easy for you
to know, I should have pointed it out:
https://lore.kernel.org/all/20210624214458.68716-1-mail@xxxxxxxxxxxxxxx/

> > +MODULE_DESCRIPTION("Awinic AW9523 I2C GPIO Expander driver");
> > +MODULE_AUTHOR("AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_ALIAS("platform:aw9523");
>
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.

Right, I'll drop it!

Thanks Krzysztof!

Yours,
Linus Walleij