Re: [PATCH v1 1/1] gpiolib: Fix the error path order in gpiochip_add_data_with_key()

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, Feb 22, 2024 at 02:39:28PM +0100, Bartosz Golaszewski wrote:
> On Thu, Feb 22, 2024 at 2:37 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Thu, Feb 22, 2024 at 05:33:59AM -0800, Bartosz Golaszewski wrote:
> > > On Thu, 22 Feb 2024 14:25:24 +0100, Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> said:
> > > > On Thu, Feb 22, 2024 at 10:37:06AM +0100, Bartosz Golaszewski wrote:
> > > >> On Wed, Feb 21, 2024 at 8:28 PM Andy Shevchenko
> > > >> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > > >> >         gpiochip_irqchip_free_valid_mask(gc);
> > > >> >  err_remove_acpi_chip:
> > > >> >         acpi_gpiochip_remove(gc);
> > > >> > +       gpiochip_remove_pin_ranges(gc);
> > > >> >  err_remove_of_chip:
> > > >> >         gpiochip_free_hogs(gc);
> > > >> >         of_gpiochip_remove(gc);
> > > >>
> > > >> This undoes machine_gpiochip_add() and I think it also needs to be
> > > >> moved before acpi_gpiochip_remove().
> > > >
> > > > You mean it should be like
> > > >
> > > >        gpiochip_irqchip_free_valid_mask(gc);
> >
> > > >        gpiochip_free_hogs(gc);
> >
> > But should it be here...
> >
> > > > err_remove_acpi_chip:
> >
> > ...or here?
> >
> > I'm sorry I really need more (morning) coffee, maybe you can simply update
> > yourself or submit a correct fix?
> 
> Ok, I'll apply this and send a fix on top of it.

I don't see any progress with this. Do I need to do something?

-- 
With Best Regards,
Andy Shevchenko