Re: [PATCH v13 2/3] iio: adc: ad_sigma_delta: Add optional irq selection

[Andy Shevchenko <andy@xxxxxxxxxx>]

On Tue, Feb 20, 2024 at 04:13:12PM +0200, Ceclan Dumitru wrote:
> On 2/20/24 16:11, Andy Shevchenko wrote:
> > On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote:

...

> >> +	if (!info->irq_num)
> >> +		sigma_delta->irq_num = spi->irq;
> >> +	else
> >> +		sigma_delta->irq_num = info->irq_num;
> > 
> > Why not positive check?
> > 
> Considered that selecting spi->irq is usually the default case, so it should
> be the first branch

Let compiler do its job, the negative conditions are harder to read/parse by
human beings.

-- 
With Best Regards,
Andy Shevchenko