On Sun, Feb 11, 2024 at 06:58:14PM +0200, Andy Shevchenko wrote: > On Sun, Feb 11, 2024 at 12:14 PM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > > > The documentation for default_values mentions high/low which can be > > confusing, particularly when the ACTIVE_LOW flag is set. > > > > Replace high/low with active/inactive to clarify that the values are > > logical not physical. > > > > Similarly, clarify the interpretation of values in struct gpiohandle_data. > > I'm not against this particular change, but I want the entire GPIO > documentation to be aligned in the terminology aspect. Is this the > case after this patch? I.o.w. have we replaced all leftovers? > Agreed. Those are the last remnants of the low/high terminolgy that I am aware of, certainly the last in gpio.h. Having a closer look to double check... Ah - it is still used in Documentation/userspace-api/gpio/sysfs.rst - not somewhere I go very often. Would you like that updated in a separate patch? Cheers, Kent.