Re: [PATCH] gpio: set device type for GPIO chips

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Feb 1, 2024 at 5:28 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> It's useful to have the device type information for those sub-devices
> that are actually GPIO chips registered with GPIOLIB. While at it: use
> the device type struct to setup the release callback which is the
> preferred way to use the device API.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
(...=
> +static struct device_type gpio_dev_type = {
> +       .name = "gpio_chip",
> +       .release = gpiodev_release,
> +};
> +       gdev->dev.type = &gpio_dev_type;
>         gdev->dev.bus = &gpio_bus_type;
>         gdev->dev.parent = gc->parent;

Looks good to me (TM) but we should run this by Greg so he get the chance
to chime in, I doubt he will see it on LKML.

FWIW:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij