Re: [PATCH] pinctrl: mcp23s08: Check only GPIOs which have interrupts enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 01, 2024 at 02:19:38PM +0200, Arturas Moskvinas wrote:
> On Thu, Feb 1, 2024 at 2:03 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> wrote:

...

> > > +             /* We must check all of the inputs with enabled interrupts
> > > +              * on the chip, otherwise we may not notice a change
> > > +              * on >=2 pins.
> >
> > Missing space after =. But better to spell in proper English, i.e.
> > "...great than or equal to 2 pins."
> >
> +               /*
> +                * We must check all of the inputs with enabled interrupts
> +                * on the chip, otherwise we may not notice a change
> +                * on more than one pin.
> 
> Does this sound better?

LGTM, thanks.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux