On Thu, Jan 25, 2024 at 08:06:35AM +0100, Michal Simek wrote: > > > On 1/24/24 17:16, Conor Dooley wrote: > > On Wed, Jan 24, 2024 at 10:07:46AM +0100, Michal Simek wrote: > > > Compatible string doesn't really match with compatible string listed in the > > > driver itself. While binding was converted from txt to yaml > > > xlnx,zynq-pinctrl was listed as compatible string but example was using > > > xlnx,pinctrl-zynq and also this string is used in all DTSes. > > > xlnx,zynq-pinctrl is used only in dt binding and not present in any DT > > > which is stable for quite a long time that's why use old compatible string > > > and update binding document instead of starting to use unused compatible > > > string. > > > > > > Fixes: 153df45acda0 ("dt-bindings: pinctrl: pinctrl-zynq: Convert to yaml") > > > Signed-off-by: Michal Simek <michal.simek@xxxxxxx> > > > > I assume that U-Boot etc all use the "incorrect" compatible as was in > > the example? If they do, then the patch seems good to me. > > Yes. U-Boot is using "incorrect" compatible string from 2015. Okay. Assuming U-Boot is the only other user, it eems reasonable to document the defacto compatible then. Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature