Re: [PATCH 1/2] dt-bindings: gpio: add adg1414

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 21/01/2024 11:35, Kim Seer Paller wrote:
> The ADG1414 is a 9.5 Ω RON ±15 V/+12 V/±5 V iCMOS Serially-Controlled
> Octal SPST Switches
> 
> Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> ---
>  .../bindings/gpio/gpio-adg1414.yaml           | 66 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml b/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
> new file mode 100644
> index 000000000..24a51e79f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml

Filename like compatible.


> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-adg1414.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADG1414 SPST Switch Driver

"Driver" as Linux driver or some hardware driver?

> +
> +maintainers:
> +  - Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> +
> +description:
> +  The ADG1414 is a 9.5 Ω RON ±15 V/+12 V/±5 V iCMOS serially-controlled
> +  octal SPST switches.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adg1414
> +
> +  reg:
> +    maxItems: 1
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  spi-cpha: true
> +
> +  reset-gpios:
> +    description: GPIO specifier that resets the device.

Drop description, it's obvious. You could instead say something useful,
like name of pin.

> +    maxItems: 1
> +
> +  '#daisy-chained-devices':
> +    description: The number of daisy-chained devices.
> +    default: 1
> +    minimum: 1
> +    maximum: 4

This needs to be added to dtschema or at least its type should be here.

> +
> +required:
> +  - compatible
> +  - reg
> +  - spi-cpha
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +


Best regards,
Krzysztof