On Mon, Jan 15, 2024 at 05:09:05PM +0100, Bartosz Golaszewski wrote: > On Mon, Jan 15, 2024 at 4:05PM Lukas Wunner <lukas@xxxxxxxxx> wrote: > > While at it drop a superfluous trailing semicolon. > > While not strictly needed here - I think it's better for readability > to have a semicolon following every statement. Any reasons for why > dropping it is better? I looked at all the DEFINE_FREE definitions in Linus' current master and this appears to be the only one with the extraneous semicolon, so one reason is consistency. Another the avoidance of the illusion that this is a proper C statement. It's basically an empty statement so it doesn't hurt but it doesn't provide any value either. Thanks, Lukas