Re: [PATCH 1/2] gpio: vf610: add support to DT 'ngpios' property

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Jan 11, 2024 at 2:20 PM Hector Palacios
<hector.palacios@xxxxxxxx> wrote:

> Default to hardcoded VF610_GPIO_PER_PORT (32 pins) but allow optional
> generic 'ngpios' property to be specified from the device tree.
>
> Signed-off-by: Hector Palacios <hector.palacios@xxxxxxxx>

Looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

NB: this only makes sense when you use GPIOs 0...n where n < 31.

We also have the .valid_mask and .init_valid_mask() callback if
you want to mask out GPIOs in the middle or beginning or so.

Yours,
Linus Walleij

Yours,
Linus Walleij