On Thu, Jan 04, 2024 at 03:12:31AM +0000, Yuklin Soo wrote: > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Sent: Thursday, December 21, 2023 11:45 PM > > To: Linus Walleij <linus.walleij@xxxxxxxxxx>; Yuklin Soo > > <yuklin.soo@xxxxxxxxxxxxxxxx> > > Cc: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>; Hal Feng > > <hal.feng@xxxxxxxxxxxxxxxx>; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; > > Jianlong Huang <jianlong.huang@xxxxxxxxxxxxxxxx>; Emil Renner Berthing > > <kernel@xxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > > Drew Fustini <drew@xxxxxxxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > > riscv@xxxxxxxxxxxxxxxxxxx; Paul Walmsley <paul.walmsley@xxxxxxxxxx>; Palmer > > Dabbelt <palmer@xxxxxxxxxxx>; Albert Ou <aou@xxxxxxxxxxxxxxxxx> > > Subject: Re: [RFC PATCH 1/6] dt-bindings: pinctrl: starfive: add JH8100 pinctrl > > bindings > > > > On 21/12/2023 14:57, Linus Walleij wrote: > > >> + drive-strength: > > >> + enum: [ 2, 4, 8, 12 ] > > > > > > Milliamperes? Then spell that out in a description: > > > > Or just use drive-strength-microamp > > Suggest changing “drive-strength:” to “drive-strength: Drive strength in mA” since the unit is in mA. Just call the property "drive-strength-microamp". We have existing users of that property. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
