Re: [PATCH v2 2/2] gpiolib: use a mutex to protect the list of GPIO devices

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Dec 08, 2023 at 11:20:20AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> The global list of GPIO devices is never modified or accessed from
> atomic context so it's fine to protect it using a mutex. Add a new
> global lock dedicated to the gpio_devices list and use it whenever
> accessing or modifying it.

...

> While at it: fold the sysfs registering of existing devices into
> gpiolib.c and make gpio_devices static within its compilation unit.

TBH I do not like injecting sysfs (legacy!) code into gpiolib.
It makes things at very least confusing.

That _ugly_ ifdeffery and sysfs in the function name are not okay.

If you want do that, please create a separate change and explain the rationale
behind with answering to the Q "Why do we need all that and why is it better
than any alternatives?".

-- 
With Best Regards,
Andy Shevchenko